Messages in this thread | | | Date | Sat, 17 Aug 2013 01:52:43 +0900 | Subject | Re: [PATCH v3 2/3] sched: factor out code to should_we_balance() | From | JoonSoo Kim <> |
| |
Hello, Peter.
2013/8/15 Peter Zijlstra <peterz@infradead.org>: > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5120,11 +5120,8 @@ static int load_balance(int this_cpu, st > > schedstat_inc(sd, lb_count[idle]); > > - if (!should_we_balance(&env)) { > - *should_balance = 0; > + if (!(*should_balance = should_we_balance(&env))) > goto out_balanced; > - } else > - *should_balance = 1; > > redo: > group = find_busiest_group(&env); >
Looks better!
Thanks!
| |