lkml.org 
[lkml]   [2013]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 3/3] sched: clean-up struct sd_lb_stat
From
>> -     if (sds->max_load < sds->avg_load) {
>> + if (busiest->avg_load < this->avg_load) {
>
> Tsk, inconsistency there.

Okay, this is my mistake.

>
>> - max_pull = min(sds->max_load - sds->avg_load, load_above_capacity);
>> + max_pull = min(busiest->avg_load - sds->sd_avg_load,
>> + load_above_capacity);
>
> you just made it possible for the above subtraction to become negative.
>
> Also not entirely sure why you renamed sds->avg_load; renaming it back.

Okay, sds->avg_load seems to be better :)

Thanks.


\
 
 \ /
  Last update: 2013-08-16 19:21    [W:0.074 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site