Messages in this thread | | | Date | Sat, 17 Aug 2013 02:09:48 +0900 | Subject | Re: [PATCH v3 3/3] sched: clean-up struct sd_lb_stat | From | JoonSoo Kim <> |
| |
>> - if (sds->max_load < sds->avg_load) { >> + if (busiest->avg_load < this->avg_load) { > > Tsk, inconsistency there.
Okay, this is my mistake.
> >> - max_pull = min(sds->max_load - sds->avg_load, load_above_capacity); >> + max_pull = min(busiest->avg_load - sds->sd_avg_load, >> + load_above_capacity); > > you just made it possible for the above subtraction to become negative. > > Also not entirely sure why you renamed sds->avg_load; renaming it back.
Okay, sds->avg_load seems to be better :)
Thanks.
| |