Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH 04/12] checkpatch: Warn on comparisons to jiffies | Date | Mon, 10 Jun 2013 15:20:42 -0700 |
| |
Comparing jiffies is almost always wrong and time_before and time_after should be used instead.
Warn on any comparison to jiffies.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 576139a..c274e1d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3299,6 +3299,12 @@ sub process { } } +# check for comparisons of jiffies + if ($line =~ /\bjiffies\s*$Compare|$Compare\s*jiffies\b/) { + WARN("JIFFIES_COMPARISON", + "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr); + } + # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { # print "#ifdef in C files should be avoided\n"; -- 1.8.1.2.459.gbcd45b4.dirty
| |