Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH 07/12] checkpatch: Add a placeholder to check blank lines before declarations | Date | Mon, 10 Jun 2013 15:20:45 -0700 |
| |
Figure out first how to determine if this is in a struct declaration or in a function body before enabling this.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 93b8e66..4ad4052 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2750,6 +2750,14 @@ sub process { "space required before the open brace '{'\n" . $herecurr); } +## # check for blank lines before declarations +## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ && +## $prevrawline =~ /^.\s*$/) { +## WARN("SPACING", +## "No blank lines before declarations\n" . $hereprev); +## } +## + # closing brace should have a space following it when it has anything # on the line if ($line =~ /}(?!(?:,|;|\)))\S/) { -- 1.8.1.2.459.gbcd45b4.dirty
| |