Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH 03/12] checkpatch: Warn when networking block comment lines don't start with * | Date | Mon, 10 Jun 2013 15:20:41 -0700 |
| |
Some block comments in network are written as:
/* block comment line 1 block comment line 2 */
Emit a warning on the "block comment line 2" because it should be
/* block comment line 1 * block comment line 2 */
This warning is only emitted on the second line of a block comment.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a3922d0..576139a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1898,6 +1898,14 @@ sub process { } if ($realfile =~ m@^(drivers/net/|net/)@ && + $prevrawline =~ /^\+[ \t]*\/\*/ && #starting /* + $prevrawline !~ /\*\/[ \t]*$/ && #no trailing */ + $rawline !~ /^\+[ \t]*\*/) { #no leading * + WARN("NETWORKING_BLOCK_COMMENT_STYLE", + "networking block comments start with * on subsequent lines\n" . $hereprev); + } + + if ($realfile =~ m@^(drivers/net/|net/)@ && $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ && #trailing */ $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ && #inline /*...*/ $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ && #trailing **/ -- 1.8.1.2.459.gbcd45b4.dirty
| |