lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] checkpatch: avoid warning on page flag acessors
Date
Using Page*() triggers a camelcase warning, but shouldn't.

Introduced by be987d9f80354e2e919926349282facd74992f90, which added the
other Page flag users.

Pipe ('|') at the end of a grouping doesn't cause the grouping to match
an emtpy string, use ? after the grouping instead to get the desired
behavior.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..ee24026 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2


\
 
 \ /
  Last update: 2013-05-14 20:01    [W:0.043 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site