Messages in this thread | | | Subject | Re: [PATCH v2] checkpatch: avoid warning on page flag acessors | From | Joe Perches <> | Date | Tue, 14 May 2013 10:13:18 -0700 |
| |
[]On Tue, 2013-05-14 at 10:06 -0700, Cody P Schafer wrote: > Using Page*() triggers a camelcase warning, but shouldn't. > > be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double > quote) breaking the regex. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2939,7 +2939,7 @@ sub process { > my $var = $1; > if ($var !~ /$Constant/ && > $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && > - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && > + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
I think you need to delete the ", leave the | and remove the ? Dunno where that " came from.
| |