lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ARM: dts: tegra: Correct PCIe entry
On Mon, Apr 08, 2013 at 08:27:00PM +0200, Stephen Warren wrote:
> On 04/08/2013 09:41 AM, Jay Agarwal wrote:
> > Signed-off-by: Jay Agarwal <jagarwal@nvidia.com>
>
> Your s-o-b line should be below the patch description, not above it.
> Please see Documentation/SubmittingPatches.
>
> I also don't see a --- line between the patch description and diffstat.
> How are you generating these patch emails? Please see our internal wiki,
> or other git documentation.
>
> > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
>
> > - clock-names = "pex", "afi", "pcie_xclk", "pll_e", "cml";
> > + clock-names = "pex", "afi", "pcie_xclk", "pll_e", "cml0";
>
> Can you please explain more about this change?
>
> I see the Tegra clock driver provides both a "cml0" and a "cml1" clock.
> Are both of those used for PCIe?
>

cml0 is used for pcie and cml1 is used for sata.

Cheers,

Peter.


\
 
 \ /
  Last update: 2013-04-09 11:21    [W:0.111 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site