Messages in this thread | | | Date | Fri, 12 Apr 2013 11:01:52 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support |
| |
On 04/12/2013 10:43 AM, Jay Agarwal wrote: >> On 04/08/2013 09:41 AM, Jay Agarwal wrote: >>> Signed-off-by: Jay Agarwal <jagarwal@nvidia.com> >>> >>> - Enable pcie root port 2 for cardhu >>> - Make private data structure for each SOC >>> - Add required tegra3 clocks and regulators >>> - Add tegra3 specific code in enable controller >>> - Modify clock tree to get clocks based on device >>> - Based on git://gitorious.org/thierryreding/linux.git >> >> A couple more points on this patch: >> >> * You didn't mention that this series is based on Thierry's work-in-progress >> tree, and not something immediately destined for upstream. As such, only >> Thierry is expected to actually apply any of these patches. >> > [>] Stephen, I have mentioned it in comment description as Based on git://gitorious.org/thierryreding/linux.git, is this not enough?
Well, first off, there are many branches there, and secondly the branch that a series is based on doesn't necessarily imply much about what you expect people to do with it.
> >> * Your changes to the Tegra PCIe driver require that device tree include >> extra clocks and regulators. You need to update >> Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt to describe >> these new requirements. > > [>] Should I create tegra30-pcie.txt? or made changes in tegra20-pcie.txt itself?
(What is "[>]"?)
It'd probably be simplest to edit tegra20-pcie.txt, and just mention the extra requirements for Tegra30.
| |