lkml.org 
[lkml]   [2013]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support
> >  	err = regulator_disable(pcie->pex_clk_supply);
> > if (err < 0)
> > - dev_err(pcie->dev, "failed to disable pex-clk regulator:
> %d\n",
> > + dev_warn(pcie->dev, "failed to disable pex-clk regulator:
> %d\n",
> > err);
> >
> > err = regulator_disable(pcie->vdd_supply);
> > if (err < 0)
> > - dev_err(pcie->dev, "failed to disable VDD regulator: %d\n",
> > + dev_warn(pcie->dev, "failed to disable VDD regulator:
> %d\n",
> > err);
>
> Please explain why that change is correct. If the regulators only exist on
> Tegra20, please represent that fact in the SoC data. Regulators must always
> exist, so enable/disable should never fail due to missing regulators. Actual
> run-time failures seem like something that really is an error.
>
[>] These regulators are needed for both tegra20 & tegra30. Since we are not returning error here, so changed to dev_warn.



\
 
 \ /
  Last update: 2013-04-12 17:21    [W:0.134 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site