Messages in this thread Patch in this message | | | Date | Sun, 07 Apr 2013 19:38:24 +0800 | From | Chen Gang <> | Subject | [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy |
| |
ownername and namebuf are all NUL terminated string.
need always let them ended by '\0'.
Signed-off-by: Chen Gang <gang.chen@asianux.com> --- kernel/module.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c index 3c2c72d..597efd8 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1283,7 +1283,7 @@ static const struct kernel_symbol *resolve_symbol(struct module *mod, getname: /* We must make copy under the lock if we failed to get ref. */ - strncpy(ownername, module_name(owner), MODULE_NAME_LEN); + strlcpy(ownername, module_name(owner), MODULE_NAME_LEN); unlock: mutex_unlock(&module_mutex); return sym; @@ -3464,7 +3464,7 @@ const char *module_address_lookup(unsigned long addr, } /* Make a copy in here where it's safe */ if (ret) { - strncpy(namebuf, ret, KSYM_NAME_LEN - 1); + strlcpy(namebuf, ret, KSYM_NAME_LEN); ret = namebuf; } preempt_enable(); -- 1.7.7.6
| |