Messages in this thread | | | Date | Fri, 5 Apr 2013 09:13:22 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] x86: build reloc tool for both 64 and 32 bit |
| |
* Kees Cook <keescook@chromium.org> wrote:
> Add logic for 64-bit kernel relocations. Since there is no need to > handle 32 and 64 bit at the same time, refactor away most of the 32/64 > bit ELF differences and split the build into producing two separate > binaries. Additionally switches to using realloc instead of a two-pass > approach. > > Heavily based on work by Neill Clift and Michael Davidson. > > Signed-off-by: Kees Cook <keescook@chromium.org> > Cc: Eric Northup <digitaleric@google.com> > --- > arch/x86/boot/compressed/Makefile | 2 +- > arch/x86/realmode/rm/Makefile | 2 +- > arch/x86/tools/.gitignore | 3 +- > arch/x86/tools/Makefile | 14 +- > arch/x86/tools/relocs.c | 717 ++++++++++++++++++++++++++----------- > arch/x86/tools/relocs_32.c | 1 + > arch/x86/tools/relocs_64.c | 2 + > 7 files changed, 533 insertions(+), 208 deletions(-) > create mode 100644 arch/x86/tools/relocs_32.c > create mode 100644 arch/x86/tools/relocs_64.c
This patch too is a bit large and it would be wise to split it into two steps: first the refactoring - which is non-functional and should not cause any problems in theory - then the change that switches to realloc.
Thanks,
Ingo
| |