lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block
Hi,

On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
> diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> index 30ea7ca..0d03a52 100644
> --- a/drivers/usb/misc/sisusbvga/Kconfig
> +++ b/drivers/usb/misc/sisusbvga/Kconfig
> @@ -1,7 +1,7 @@
>
> config USB_SISUSBVGA
> tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> - depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> + depends on (USB_MUSB_HDRC || USB_EHCI_HCD)

is it just me or would everybody agree that depending on MUSB or EHCI
here is wrong ?

> diff --git a/drivers/usb/mon/Kconfig b/drivers/usb/mon/Kconfig
> index 635745f..5c6ffa2 100644
> --- a/drivers/usb/mon/Kconfig
> +++ b/drivers/usb/mon/Kconfig
> @@ -4,7 +4,6 @@
>
> config USB_MON
> tristate "USB Monitor"
> - depends on USB
> help
> If you select this option, a component which captures the USB traffic
> between peripheral-specific drivers and HC drivers will be built.
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index 05e5143..4636ab9 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -6,7 +6,7 @@
> # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
> config USB_MUSB_HDRC
> tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> - depends on USB && USB_GADGET
> + depends on USB_GADGET

great, except for the question above:

Acked-by: Felipe Balbi <balbi@ti.com>

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-04-04 20:01    [W:0.093 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site