lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block
On Thu, 4 Apr 2013, Felipe Balbi wrote:

> Hi,
>
> On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
> > diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> > index 30ea7ca..0d03a52 100644
> > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > @@ -1,7 +1,7 @@
> >
> > config USB_SISUSBVGA
> > tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> > - depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> > + depends on (USB_MUSB_HDRC || USB_EHCI_HCD)
>
> is it just me or would everybody agree that depending on MUSB or EHCI
> here is wrong ?

That line certainly looks like it could be removed entirely. Perhaps
the original author can enlighten us.

In any case, it's not relevant to the purpose of this patch set.

Alan Stern



\
 
 \ /
  Last update: 2013-04-04 20:21    [W:0.067 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site