Messages in this thread Patch in this message | | | Subject | [PATCH RESEND] regulator: palmas: Fix off-by-one for ramp_delay and register value mapping | From | Axel Lin <> | Date | Mon, 22 Apr 2013 18:22:49 +0800 |
| |
Datasheet says: Time Step (TSTEP) selection, when changing the output voltage, the new value is reached through successive voltage steps (if not bypassed). The equivalent programmable slew rate of the output voltage is:
TSTEP[1:0]: 00 Jump (no slope control) TSTEP[1:0]: 01 10mV/us TSTEP[1:0]: 10 5mV/us (default) TSTEP[1:0]: 11 2.5mV/us
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- This resend updates the commit log.
drivers/regulator/palmas-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 8fed60c..e3e8373 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -447,9 +447,9 @@ static int palmas_smps_set_ramp_delay(struct regulator_dev *rdev, if (ramp_delay <= 0) reg = 0; - else if (ramp_delay < 2500) + else if (ramp_delay <= 2500) reg = 3; - else if (ramp_delay < 5000) + else if (ramp_delay <= 5000) reg = 2; else reg = 1; -- 1.7.10.4
| |