lkml.org 
[lkml]   [2013]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/10] mm: vmscan: Check if kswapd should writepage once per priority
On Sun 17-03-13 13:04:15, Mel Gorman wrote:
> Currently kswapd checks if it should start writepage as it shrinks
> each zone without taking into consideration if the zone is balanced or
> not. This is not wrong as such but it does not make much sense either.
> This patch checks once per priority if kswapd should be writing pages.

Except it is not once per priority strictly speaking... It doesn't make
any difference though.

> Signed-off-by: Mel Gorman <mgorman@suse.de>

Reviewed-by: Michal Hocko <mhocko@suse.cz>

> ---
> mm/vmscan.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 84375b2..8c66e5a 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2804,6 +2804,13 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
> }
>
> /*
> + * If we're getting trouble reclaiming, start doing writepage
> + * even in laptop mode.
> + */
> + if (sc.priority < DEF_PRIORITY - 2)
> + sc.may_writepage = 1;
> +
> + /*
> * Now scan the zone in the dma->highmem direction, stopping
> * at the last zone which needs scanning.
> *
> @@ -2876,13 +2883,6 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
> nr_to_reclaim += sc.nr_to_reclaim;
> }
>
> - /*
> - * If we're getting trouble reclaiming, start doing
> - * writepage even in laptop mode.
> - */
> - if (sc.priority < DEF_PRIORITY - 2)
> - sc.may_writepage = 1;
> -
> if (zone->all_unreclaimable) {
> if (end_zone && end_zone == i)
> end_zone--;
> --
> 1.8.1.4
>

--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2013-03-21 18:41    [W:0.634 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site