Messages in this thread | | | Date | Sun, 17 Mar 2013 15:08:07 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 02/10] mm: vmscan: Obey proportional scanning requirements for kswapd |
| |
On Sun, Mar 17, 2013 at 07:39:37AM -0700, Andi Kleen wrote: > Mel Gorman <mgorman@suse.de> writes: > > + > > + /* > > + * For direct reclaim, reclaim the number of pages requested. Less > > + * care is taken to ensure that scanning for each LRU is properly > > + * proportional. This is unfortunate and is improper aging but > > + * minimises the amount of time a process is stalled. > > + */ > > + if (!current_is_kswapd()) { > > + if (nr_reclaimed >= nr_to_reclaim) { > > + for_each_evictable_lru(l) > > Don't we need some NUMA awareness here? > Similar below. >
Of what sort? In this context we are usually dealing with a zone and in the case of kswapd it is only ever dealing with a single node.
-- Mel Gorman SUSE Labs
| |