lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pciehp: Add pciehp_surprise module option
At Wed, 20 Mar 2013 19:12:50 +0000,
Matthew Garrett wrote:
>
> On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > At Wed, 20 Mar 2013 17:52:34 +0000,
> > Matthew Garrett wrote:
> > > Well that just sounds like a bug. What's the downside to just ignoring
> > > that capability bit?
> >
> > I'm afraid that it's too radical to enable always.
>
> Why?

Because I'm conservative :)
Well, dunno. It's just my feeling without deep thought.

> > Or, what about to check this bit only for disable path?
>
> What happens if you unplug the device on one of the affected machines?

It continues working. I mean, the PCI device is still there after
unplug, but the Realtek driver unmounts it smoothly. Re-plugging also
works, too. So, the handling via pciehp is needed only for the very
first time to register the PCI device.


Takashi


\
 
 \ /
  Last update: 2013-03-20 21:03    [W:0.041 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site