lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pciehp: Add pciehp_surprise module option
On Wed, Mar 20, 2013 at 08:23:39PM +0100, Takashi Iwai wrote:
> At Wed, 20 Mar 2013 19:12:50 +0000,
> Matthew Garrett wrote:
> > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote:
> > > I'm afraid that it's too radical to enable always.
> >
> > Why?
>
> Because I'm conservative :)
> Well, dunno. It's just my feeling without deep thought.

Adding a parameter means it's broken until people discover that they
need to pass a parameter to make it work, and many people will just be
stuck with it not working. It really should be the last resort.

> > > Or, what about to check this bit only for disable path?
> >
> > What happens if you unplug the device on one of the affected machines?
>
> It continues working. I mean, the PCI device is still there after
> unplug, but the Realtek driver unmounts it smoothly. Re-plugging also
> works, too. So, the handling via pciehp is needed only for the very
> first time to register the PCI device.

But if I plug in a different device, things will be broken, right?

--
Matthew Garrett | mjg59@srcf.ucam.org


\
 
 \ /
  Last update: 2013-03-20 21:03    [W:0.051 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site