lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c
Date
On Tue, 19 Mar 2013 10:50:02 -0400, Steven Rostedt wrote:
> On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote:
>> free(version);
>> @@ -331,11 +354,12 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe)
>>
>> page_size = read4(pevent);
>>
>> - read_header_files(pevent);
>> - read_ftrace_files(pevent);
>> - read_event_files(pevent);
>> - read_proc_kallsyms(pevent);
>> - read_ftrace_printk(pevent);
>> + if (read_header_files(pevent) ||
>> + read_ftrace_files(pevent) ||
>> + read_event_files(pevent) ||
>> + read_proc_kallsyms(pevent) ||
>> + read_ftrace_printk(pevent))
>> + goto out;
>
> I think I like the err += func() and check for err < 0, better.

Okay, I'll change them to err |= func() style if you're fine as Peter
suggested.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-03-20 02:41    [W:0.085 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site