Messages in this thread | | | Subject | Re: [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c | From | Steven Rostedt <> | Date | Tue, 19 Mar 2013 10:50:02 -0400 |
| |
On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: > free(version); > @@ -331,11 +354,12 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe) > > page_size = read4(pevent); > > - read_header_files(pevent); > - read_ftrace_files(pevent); > - read_event_files(pevent); > - read_proc_kallsyms(pevent); > - read_ftrace_printk(pevent); > + if (read_header_files(pevent) || > + read_ftrace_files(pevent) || > + read_event_files(pevent) || > + read_proc_kallsyms(pevent) || > + read_ftrace_printk(pevent)) > + goto out;
I think I like the err += func() and check for err < 0, better.
-- Steve
> > size = calc_data_size - 1; > calc_data_size = 0;
| |