lkml.org 
[lkml]   [2013]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c
From
Date
On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote:
> free(version);
> @@ -331,11 +354,12 @@ ssize_t trace_report(int fd, struct pevent **ppevent, bool __repipe)
>
> page_size = read4(pevent);
>
> - read_header_files(pevent);
> - read_ftrace_files(pevent);
> - read_event_files(pevent);
> - read_proc_kallsyms(pevent);
> - read_ftrace_printk(pevent);
> + if (read_header_files(pevent) ||
> + read_ftrace_files(pevent) ||
> + read_event_files(pevent) ||
> + read_proc_kallsyms(pevent) ||
> + read_ftrace_printk(pevent))
> + goto out;

I think I like the err += func() and check for err < 0, better.

-- Steve

>
> size = calc_data_size - 1;
> calc_data_size = 0;




\
 
 \ /
  Last update: 2013-03-19 16:21    [W:0.135 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site