Messages in this thread | | | Date | Wed, 20 Mar 2013 10:27:24 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c |
| |
Em Wed, Mar 20, 2013 at 10:25:52AM +0900, Namhyung Kim escreveu: > On Tue, 19 Mar 2013 10:55:28 -0400, Steven Rostedt wrote: > > On Tue, 2013-03-19 at 17:53 +0900, Namhyung Kim wrote: > >> Convert them to pr_debug() and propagate error code.
> > Shouldn't they be pr_err(). I mean, if the old code would kill the > > process, why just keep it as a debug output?
> Please see my other reply.
Ditto.
> Arnaldo, can you give me your direction/preference?
Yeah, I think that lower levels should emit a debug if it helps developers and advanced users to remedy or at least understand the situation.
The builtin-foo.c top level and the [TG]UI routines are the ones that must emit messages to the user.
- Arnaldo
| |