Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be) | Date | Thu, 7 Feb 2013 08:33:15 +0000 |
| |
On Thursday 07 February 2013, Geert Uytterhoeven wrote: > > On Thu, Feb 7, 2013 at 9:01 AM, Michal Simek <monstr@monstr.eu> wrote: > > ok. Can you please confirm with me that the same problem is also for > > iowrite32be > > ioread16be and ioread32be? > > > > This description seems to me correct for BE and LE. > > #define ioread16be(addr) __be16_to_cpu(__raw_readw(addr)) > > #define ioread32be(addr) __be32_to_cpu(__raw_readl(addr)) > > > > #define iowrite16be(v, addr) __raw_writew(__cpu_to_be16(v), addr) > > #define iowrite32be(v, addr) __raw_writel(__cpu_to_be32(v), addr) > > > > What do you think? > > Looks fine to me. Arnd, Ben?
Yes, that would be better. Can you prepare a patch?
Arnd
| |