lkml.org 
[lkml]   [2013]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)
Date
On Thursday 07 February 2013, Geert Uytterhoeven wrote:
>
> On Thu, Feb 7, 2013 at 9:01 AM, Michal Simek <monstr@monstr.eu> wrote:
> > ok. Can you please confirm with me that the same problem is also for
> > iowrite32be
> > ioread16be and ioread32be?
> >
> > This description seems to me correct for BE and LE.
> > #define ioread16be(addr) __be16_to_cpu(__raw_readw(addr))
> > #define ioread32be(addr) __be32_to_cpu(__raw_readl(addr))
> >
> > #define iowrite16be(v, addr) __raw_writew(__cpu_to_be16(v), addr)
> > #define iowrite32be(v, addr) __raw_writel(__cpu_to_be32(v), addr)
> >
> > What do you think?
>
> Looks fine to me. Arnd, Ben?

Yes, that would be better. Can you prepare a patch?

Arnd


\
 
 \ /
  Last update: 2013-02-07 10:01    [W:0.120 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site