Messages in this thread | | | Date | Thu, 7 Feb 2013 09:20:18 +0100 | Subject | Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be) | From | Geert Uytterhoeven <> |
| |
On Thu, Feb 7, 2013 at 9:01 AM, Michal Simek <monstr@monstr.eu> wrote: > ok. Can you please confirm with me that the same problem is also for > iowrite32be > ioread16be and ioread32be? > > This description seems to me correct for BE and LE. > #define ioread16be(addr) __be16_to_cpu(__raw_readw(addr)) > #define ioread32be(addr) __be32_to_cpu(__raw_readl(addr)) > > #define iowrite16be(v, addr) __raw_writew(__cpu_to_be16(v), addr) > #define iowrite32be(v, addr) __raw_writel(__cpu_to_be32(v), addr) > > What do you think?
Looks fine to me. Arnd, Ben?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |