Messages in this thread | | | Date | Thu, 7 Feb 2013 15:19:35 +0100 | Subject | Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be) | From | Michal Simek <> |
| |
2013/2/7 Arnd Bergmann <arnd@arndb.de>: > On Thursday 07 February 2013, Geert Uytterhoeven wrote: >> >> On Thu, Feb 7, 2013 at 9:01 AM, Michal Simek <monstr@monstr.eu> wrote: >> > ok. Can you please confirm with me that the same problem is also for >> > iowrite32be >> > ioread16be and ioread32be? >> > >> > This description seems to me correct for BE and LE. >> > #define ioread16be(addr) __be16_to_cpu(__raw_readw(addr)) >> > #define ioread32be(addr) __be32_to_cpu(__raw_readl(addr)) >> > >> > #define iowrite16be(v, addr) __raw_writew(__cpu_to_be16(v), addr) >> > #define iowrite32be(v, addr) __raw_writel(__cpu_to_be32(v), addr) >> > >> > What do you think? >> >> Looks fine to me. Arnd, Ben? > > Yes, that would be better. Can you prepare a patch?
Done: Subject: "asm-generic: io: Fix ioread16/32be and iowrite16/32be"
Thanks, Michal
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
| |