Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put | From | Ian Campbell <> | Date | Tue, 19 Feb 2013 08:58:44 +0000 |
| |
On Tue, 2013-02-19 at 08:03 +0000, Jan Beulich wrote: > >>> On 19.02.13 at 06:53, David Miller <davem@davemloft.net> wrote: > > From: Andrew Jones <drjones@redhat.com> > > Date: Mon, 18 Feb 2013 21:29:20 +0100 > > > >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does > >> a xenvif_put(). As callers of netbk_fatal_tx_err should only > >> have one reference to the vif at this time, then the xenvif_put > >> in netbk_fatal_tx_err is one too many. > >> > >> Signed-off-by: Andrew Jones <drjones@redhat.com> > > > > Applied. > > But this is wrong from all we can tell,
Yes, please can this be reverted.
> we discussed this before > (Wei pointed to the discussion in an earlier reply). The core of > it is that the put here parallels the one in netbk_tx_err(), and > the one in xenvif_carrier_off() matches the get from > xenvif_connect() (which normally would be done on the path > coming through xenvif_disconnect()).
Perhaps Andrew was looking at the tree before "xen-netback: correctly return errors from netbk_count_requests()" which fixed a different case of a double put which may have appeared to be fixed by this change too.
Ian.
> And anyway - shouldn't changes to netback require an ack from > Ian? > > Jan >
| |