Messages in this thread | | | Date | Tue, 19 Feb 2013 13:06:07 -0500 (EST) | Subject | Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put | From | David Miller <> |
| |
From: Ian Campbell <Ian.Campbell@citrix.com> Date: Tue, 19 Feb 2013 08:58:44 +0000
> On Tue, 2013-02-19 at 08:03 +0000, Jan Beulich wrote: >> >>> On 19.02.13 at 06:53, David Miller <davem@davemloft.net> wrote: >> > From: Andrew Jones <drjones@redhat.com> >> > Date: Mon, 18 Feb 2013 21:29:20 +0100 >> > >> >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does >> >> a xenvif_put(). As callers of netbk_fatal_tx_err should only >> >> have one reference to the vif at this time, then the xenvif_put >> >> in netbk_fatal_tx_err is one too many. >> >> >> >> Signed-off-by: Andrew Jones <drjones@redhat.com> >> > >> > Applied. >> >> But this is wrong from all we can tell, > > Yes, please can this be reverted.
Done and I've annotated the revert commit message with as much information as possible.
| |