[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[ 64/89] x86, efi: Fix display detection in EFI boot stub
3.7-stable review patch.  If anyone has any objections, please let me know.


From: David Woodhouse <>

commit 70a479cbe80296d3113e65cc2f713a5101061daf upstream.

When booting under OVMF we have precisely one GOP device, and it
implements the ConOut protocol.

We break out of the loop when we look at it... and then promptly abort
because 'first_gop' never gets set. We should set first_gop *before*
breaking out of the loop. Yes, it doesn't really mean "first" any more,
but that doesn't matter. It's only a flag to indicate that a suitable
GOP was found.

In fact, we'd do just as well to initialise 'width' to zero in this
function, then just check *that* instead of first_gop. But I'll do the
minimal fix for now (and for stable@).

Signed-off-by: David Woodhouse <>
Signed-off-by: H. Peter Anvin <>
Cc: Matt Fleming <>
Signed-off-by: Greg Kroah-Hartman <>

arch/x86/boot/compressed/eboot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -316,10 +316,9 @@ static efi_status_t setup_gop(struct scr
* Once we've found a GOP supporting ConOut,
* don't bother looking any further.
+ first_gop = gop;
if (conout_found)
- first_gop = gop;

 \ /
  Last update: 2013-02-01 15:21    [W:0.290 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site