[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[ 75/89] xfs: fix periodic log flushing
    3.7-stable review patch.  If anyone has any objections, please let me know.


    From: Dave Chinner <>

    [Please take this patch for -stable in kernels 3.5-3.7. It doesn't have an
    equivalent upstream commit because the code was removed before the bug was
    discovered. See f661f1e0bf50 and 7e18530bef6a.]

    There is a logic inversion in xfssyncd_worker() which means that the
    log is not periodically forced or idled correctly. This means that
    metadata changes aggregated in memory do not get flushed in a timely
    manner, and hence if filesystem is not cleanly unmounted those
    changes can be lost. This loss can manifest itself even hours after
    the changes were made if the filesystem is left to idle without a
    sync() occurring between the last modification and the
    crash/shutdown occuring.

    Signed-off-by: Dave Chinner <>
    Reviewed-by: Ben Myers <>
    Signed-off-by: Ben Myers <>
    Signed-off-by: Greg Kroah-Hartman <>

    fs/xfs/xfs_sync.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    If people agree the fix is correct, I'll post it to the -stable
    list for inclusion...

    --- a/fs/xfs/xfs_sync.c
    +++ b/fs/xfs/xfs_sync.c
    @@ -400,7 +400,7 @@ xfs_sync_worker(
    * cancel_delayed_work_sync on this work queue before tearing down
    * the ail and the log in xfs_log_unmount.
    - if (!(mp->m_super->s_flags & MS_ACTIVE) &&
    + if ((mp->m_super->s_flags & MS_ACTIVE) &&
    !(mp->m_flags & XFS_MOUNT_RDONLY)) {
    /* dgc: errors ignored here */
    if (mp->m_super->s_writers.frozen == SB_UNFROZEN &&

     \ /
      Last update: 2013-02-01 15:21    [W:4.246 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site