[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers v3

* Andi Kleen <> wrote:

> From: Andi Kleen <>
> Implement the TSX transaction and checkpointed transaction qualifiers for
> Haswell. This allows e.g. to profile the number of cycles in transactions.
> The checkpointed qualifier requires forcing the event to
> counter 2, implement this with a custom constraint for Haswell.
> Also add sysfs format attributes for intx/intx_cp

The series is getting smaller, but you still included this patch
I pointed out in my last review, which unnecessary increases the
size of the initial hw support series by adding Haswell-specific
transaction profiling features.

As requested before, please keep those in a completely separate
series so that minimal support can be merged upstream. This is
how we always did new hardware support in the past, in iterative
steps, and we are not going to make an exception for you.

I find it pretty counterproductive that you have ignored my
previous series structure request. Every unnecessary delay you
cause here delays upstream profiling support for Haswell CPUs.



 \ /
  Last update: 2013-02-01 11:43    [W:0.101 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site