lkml.org 
[lkml]   [2013]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/5] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC
From
Date
On Wed, 2013-12-18 at 13:47 +0000, Mark Brown wrote:
> On Tue, Dec 17, 2013 at 02:23:20PM +0100, Krzysztof Kozlowski wrote:
>
> > +static int s5m8767_reg_gpio_is_enabled(struct regulator_dev *rdev)
> > +{
> > + struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev);
> > + int val;
> > +
> > + if (!s5m8767->buck9_uses_gpio)
> > + return s5m8767_reg_is_enabled(rdev);
> > +
> > + val = gpio_get_value(s5m8767->buck9_gpio);
> > +
> > + return val == 1;
> > +}
>
> Don't open code this, use the core GPIO handling - see ena_gpio.

OK, I'll rewrite the patch.

Best regards,
Krzysztof



\
 
 \ /
  Last update: 2013-12-18 16:41    [W:0.117 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site