Messages in this thread | | | Date | Wed, 18 Dec 2013 13:47:20 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 4/5] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC |
| |
On Tue, Dec 17, 2013 at 02:23:20PM +0100, Krzysztof Kozlowski wrote:
> +static int s5m8767_reg_gpio_is_enabled(struct regulator_dev *rdev) > +{ > + struct s5m8767_info *s5m8767 = rdev_get_drvdata(rdev); > + int val; > + > + if (!s5m8767->buck9_uses_gpio) > + return s5m8767_reg_is_enabled(rdev); > + > + val = gpio_get_value(s5m8767->buck9_gpio); > + > + return val == 1; > +}
Don't open code this, use the core GPIO handling - see ena_gpio. [unhandled content-type:application/pgp-signature] | |