Messages in this thread | | | Date | Tue, 17 Dec 2013 13:49:28 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 4/5] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC |
| |
On Tue, 17 Dec 2013, Krzysztof Kozlowski wrote:
> Add support for GPIO control (enable/disable) over Buck9. The Buck9 > Converter is used as a supply for eMMC Host Controller. > > BUCK9EN GPIO of S5M8767 chip may be used by application processor to > enable or disable the Buck9. This has two benefits: > - It is faster than toggling it over I2C bus. > - It allows disabling the regulator during suspend to RAM; The AP will > enable it during resume; Without the patch the regulator supplying > eMMC must be defined as fixed-regulator. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/regulator/s5m8767.c | 120 ++++++++++++++++++++++++++++++++++- > include/linux/mfd/samsung/core.h | 2 + > include/linux/mfd/samsung/s5m8767.h | 7 ++
So long as they fit in with the rest of the changes, the MFD adaptions look fine to me:
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |