Messages in this thread | | | From | David Cohen <> | Subject | [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart | Date | Thu, 12 Dec 2013 21:18:22 -0800 |
| |
Hi,
These patches are proposal to extend the lack of #ifdef checks on PM callback to its implementation too.
Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting the callback to PM ops, but the callbacks implementation don't see same benefit.
This RFC Solves a problem reported by Santosh on xhci-plat.c driver due to wrong #ifdef checks:
drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function] drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
But instead of fixing the #ifdefs, we remove the need for it :)
Br, David Cohen
--- David Cohen (2): pm: make PM macros more smart usb/xhci: implement proper static inline stubs when !CONFIG_PM
Santosh Shilimkar (1): usb/xhci-plat: remove unnecessary #ifdef checks for CONFIG_PM_SLEEP
drivers/usb/host/xhci-plat.c | 7 +------ drivers/usb/host/xhci.h | 6 ++++-- include/linux/pm.h | 11 +++++++++-- 3 files changed, 14 insertions(+), 10 deletions(-)
-- 1.8.4.2
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |