Messages in this thread Patch in this message | | | Date | Thu, 12 Dec 2013 13:47:25 +1100 | From | Anton Blanchard <> | Subject | [PATCH] perf symbols: symbol-minimal.c causes random fd to be closed |
| |
I hit a cryptic failure when testing a recent version of perf:
# perf report write failure on standard output: Bad file descriptor
The issue is in commit b68e2f91 (perf symbols: Introduce symsrc structure). symsrc__destroy() does a close(ss->fd) but ss->fd is only initialised in the symbol-elf.c case and not for symbol-minimal.c.
The issue has been around for a while however most people will build with libelf which wont use the symbol-minimal.c code.
Cc: stable@vger.kernel.org # v3.8+ Signed-off-by: Anton Blanchard <anton@samba.org> ---
diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c index 2d2dd05..3528204 100644 --- a/tools/perf/util/symbol-minimal.c +++ b/tools/perf/util/symbol-minimal.c @@ -254,6 +254,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso __maybe_unused, goto out_close; ss->type = type; + ss->fd = fd; return 0; out_close:
| |