Messages in this thread | | | Date | Thu, 12 Dec 2013 11:21:21 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf symbols: symbol-minimal.c causes random fd to be closed |
| |
Em Thu, Dec 12, 2013 at 01:47:25PM +1100, Anton Blanchard escreveu: > > I hit a cryptic failure when testing a recent version > of perf: > > # perf report > write failure on standard output: Bad file descriptor > > The issue is in commit b68e2f91 (perf symbols: Introduce symsrc > structure). symsrc__destroy() does a close(ss->fd) but > ss->fd is only initialised in the symbol-elf.c case and > not for symbol-minimal.c. > > The issue has been around for a while however most people > will build with libelf which wont use the symbol-minimal.c > code. > > Cc: stable@vger.kernel.org # v3.8+ > Signed-off-by: Anton Blanchard <anton@samba.org>
This was fixed recently, yeah, should go to stable as well:
commit 779e24e2c777bffa9a6e3d5e821859e67008c98b Author: Adrian Hunter <adrian.hunter@intel.com> Date: Wed Dec 4 16:23:01 2013 +0200
perf symbols: Fix random fd closing with no libelf
> --- > > diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c > index 2d2dd05..3528204 100644 > --- a/tools/perf/util/symbol-minimal.c > +++ b/tools/perf/util/symbol-minimal.c > @@ -254,6 +254,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso __maybe_unused, > goto out_close; > > ss->type = type; > + ss->fd = fd; > > return 0; > out_close:
| |