Messages in this thread | | | Date | Fri, 8 Nov 2013 12:00:01 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc |
| |
On Fri, Nov 08, 2013 at 05:06:10PM +0200, Pantelis Antoniou wrote: > Add a runtime interface to /proc to enable generic device tree overlay > usage. >
Hi Pantelis,
> --- > fs/proc/proc_devtree.c | 278 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 278 insertions(+) > [ ... ]
> + > + /* start at 256K at first */ > + if (od->alloc == 0) > + od->alloc = SZ_256K / 2; > +
I have to include <linux/sizes.h> to get this to build.
Also, even though /proc/device-tree-overlay is supposed to be write only, I get this:
# cat /proc/device-tree-overlay cat: [ 651.973568] overlay_proc_release: failed to unflatten tree /proc/device-tree-overlay: Input/output error
which seems to be a bit odd. I did not spend any time to track it down, though.
Otherwise, the code seems to be working well.
Thanks, Guenter
| |