lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
From
Date
Hi Ionut,

On Nov 11, 2013, at 11:22 AM, Ionut Nicu wrote:

> Hi,
>
> On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
>> Add a runtime interface to /proc to enable generic device tree overlay
>> usage.
>>
>
>> +
>> + /* start at 256K at first */
>> + if (od->alloc == 0)
>> + od->alloc = SZ_256K / 2;
>> +
>
> Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
> the code will not build.
>

OK, I guess on my platform it gets implicitly included.

>> + rcu_read_lock();
>> + idr_for_each_entry(&overlay_idr, od, id) {
>> + seq_printf(m, "%d: %d bytes", id, od->size);
>
> For od->size we should use "%zu", otherwise there will be a compilation warning.
> At least I get one on mips64...
>

Both of these will be included on the next revision of the patchset.

> Otherwise, I've tested this and it works fine for me also.
>
> Thanks,
> Ionut

Regards

-- Pantelis



\
 
 \ /
  Last update: 2013-11-11 13:41    [W:0.098 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site