lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
    Hi,

    On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
    > Add a runtime interface to /proc to enable generic device tree overlay
    > usage.
    >

    > +
    > + /* start at 256K at first */
    > + if (od->alloc == 0)
    > + od->alloc = SZ_256K / 2;
    > +

    Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
    the code will not build.

    > + rcu_read_lock();
    > + idr_for_each_entry(&overlay_idr, od, id) {
    > + seq_printf(m, "%d: %d bytes", id, od->size);

    For od->size we should use "%zu", otherwise there will be a compilation warning.
    At least I get one on mips64...

    Otherwise, I've tested this and it works fine for me also.

    Thanks,
    Ionut


    \
     
     \ /
      Last update: 2013-11-11 11:41    [W:3.060 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site