Messages in this thread | | | Date | Tue, 29 Jan 2013 17:58:48 -0500 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all() |
| |
On Fri, Jan 25, 2013 at 05:31:09PM -0800, Tejun Heo wrote: > idr_destroy() can destroy idr by itself and idr_remove_all() is being > deprecated. Drop reference to idr_remove_all(). Note that the code > wasn't completely correct before because idr_remove() on all entries > doesn't necessarily release all idr_layers which could lead to memory > leak.
Seems fine, but actually this is client-side so I think you meant the cc to be to Trond.
--b.
> > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: "J. Bruce Fields" <bfields@fieldses.org> > Cc: linux-nfs@vger.kernel.org > --- > This patch depends on an earlier idr patch and given the trivial > nature of the patch, I think it would be best to route these together > through -mm. Please holler if there's any objection. > > Thanks. > > fs/nfs/client.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/nfs/client.c b/fs/nfs/client.c > index 9f3c664..84d8eae 100644 > --- a/fs/nfs/client.c > +++ b/fs/nfs/client.c > @@ -197,7 +197,6 @@ error_0: > EXPORT_SYMBOL_GPL(nfs_alloc_client); > > #if IS_ENABLED(CONFIG_NFS_V4) > -/* idr_remove_all is not needed as all id's are removed by nfs_put_client */ > void nfs_cleanup_cb_ident_idr(struct net *net) > { > struct nfs_net *nn = net_generic(net, nfs_net_id); > -- > 1.8.1 >
| |