Messages in this thread | | | Date | Mon, 4 Feb 2013 10:35:08 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all() |
| |
Hey,
On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote: > you assign id1 to 0, so this never happens i think. i don't think the > reason to preassign id1/id2 exists anymore once the do loop is removed. > > > + id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC); > > + if (id1 < 0) { > > + err = id1; > > you dont need to assign err since it isn't returned.
Heh, I put v2 under the wrong thread. I'll do v3 and post it under v1.
Thanks.
-- tejun
| |