Messages in this thread | | | Date | Thu, 31 Jan 2013 16:08:12 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all() |
| |
Hello, Trond.
On Wed, Jan 30, 2013 at 02:18:06AM +0000, Myklebust, Trond wrote: > My worry is more about Tejun's comment that we did actually need a call > to idr_remove_all() in the original code. Do we need to queue up a fix > for the 3.8 and existing stable kernels?
IIUC, the only case where idr_layer is left around after idr_remove() on all elems is when the deletions lead to multi-level left-most collapse. Not sure whether the current code can actually hit that. No harm in adding idr_remove_all(), I guess.
Thanks.
-- tejun
| |