| Subject | Re: [PATCH 04/31] perf, core: Add generic intx/intx_checkpointed counter modifiers | From | Peter Zijlstra <> | Date | Fri, 28 Sep 2012 11:02:00 +0200 |
| |
On Thu, 2012-09-27 at 21:31 -0700, Andi Kleen wrote: > + intx : 1, /* count inside transaction */ > + intx_checkpointed : 1, /* checkpointed in transaction */
I really hate those names.. what are they called in transactional memory literature?
Also do we really need this? Using the event format stuff we could equally well do:
{cpu/cycles/, cpu/cycles,intx/, cpu/cycles,intx_checkpointed/}
No need to push those bits through perf_event_attr::flags when you can stuff then through perf_event_attr::config, esp. for very hardware specific features.
|