Messages in this thread | | | Date | Mon, 9 Jul 2012 16:00:35 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v2 1/5] uprobes: don't recheck vma/f_mapping in write_opcode() |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-06-24 17:00:02]:
> write_opcode() rechecks valid_vma() and ->f_mapping, this is pointless. > The caller, register_for_each_vma() or uprobe_mmap(), has already done > these checks under mmap_sem. > > To clarify, uprobe_mmap() checks valid_vma() only, but we can rely on > build_probe_list(vm_file->f_mapping->host). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| |