Messages in this thread | | | Date | Mon, 9 Jul 2012 15:59:52 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v2 3/5] uprobes: kill write_opcode()->lock_page(new_page) |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-06-24 17:00:35]:
> write_opcode() does lock_page(new_page) for no reason. Nobody can > see this page until __replace_page() exposes it under ptl lock, and > we do nothing with this page after pte_unmap_unlock(). > > If nothing else, the similar code in do_wp_page() doesn't lock the > new page for page_add_new_anon_rmap/set_pte_at_notify. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju<srikar@linux.vnet.ibm.com>
| |