Messages in this thread | | | Date | Mon, 9 Jul 2012 11:12:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 0/5] uprobes: write_opcode() cleanups |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> On 07/06, Oleg Nesterov wrote: > > > > On 07/06, Ingo Molnar wrote: > > > > > > * Oleg Nesterov <oleg@redhat.com> wrote: > > > > > > > Hello, > > > > > > > > write_opcode() cleanups resend + new minor fix. > > > > > > > > Changes: > > > > > > > > - document the new argument in 2/5. > > > > > > > > - drop the buggy 5/5, thanks Anton for your quick nack. > > > > Probably I'll return to this later, I have another reason > > > > for this change. > > > > > > > > - so this 5/5 is new. > > > > > > > > Srikar, please add your acks unless you have some objections. > > > > > > Just wondering what's the review status of patches #1-#4? > > > > I hope Srikar will ack 1-4 soon. > > > > He observed the testing failures, but it turns out this series > > is innocent. > > > > I'll send more fixes soon. > > > > > I'll skip #5 based on Oleg's request, > > > > Yes, thanks. I still think 5/5 makes sense, but we need to do > > something with uprobe.s:vma_address() first. > > Argh. > > I wrote this email because I wanted to say that I updated the > changelog for 2/5 a little bit, but forgot to mention this. > I'll send the updated patch in reply to 2/5 (once again, only > the changelog was changed). But please let me know if you want > me to resend 1-4.
Once Srikar's ack is in then it would be nice to update the patches with the ack and resend #1-#4, to make sure I have all the intended patches and nothing more or less than that.
Thanks,
Ingo
| |