Messages in this thread | | | Subject | Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings | From | Joe Perches <> | Date | Thu, 26 Jul 2012 22:03:39 -0700 |
| |
On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: > fixed some checkpatch warnings. > (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) [] > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c [] > @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init) > > ver = dcon_read(dcon, DCON_REG_ID); > if ((ver >> 8) != 0xDC) { > - printk(KERN_ERR "olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n", > - ver); > + pr_err("DCON ID not 0xDCxx: 0x%04x instead.\n", > + ver);
Please fit arguments on a single line where feasible.
pr_err("DCON ID not 0xDCxx: 0x%04x instead.\n", ver); []
> @@ -231,7 +232,7 @@ static void dcon_sleep(struct dcon_priv *dcon, bool sleep) > dcon->disp_mode |= MODE_BL_ENABLE; > x = dcon_bus_stabilize(dcon, 1); > if (x) > - printk(KERN_WARNING "olpc-dcon: unable to reinit dcon hardware: %d!\n", > + pr_warn("unable to reinit dcon hardware: %d!\n", > x);
pr_warn("unable to reinit dcon hardware: %d!\n", x);
etc.
| |