Messages in this thread | | | Date | Thu, 26 Jul 2012 19:28:03 -0700 | From | Andres Salomon <> | Subject | Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings |
| |
On Fri, 27 Jul 2012 08:49:19 +0900 Toshiaki Yamane <yamanetoshi@gmail.com> wrote:
> Now checkpatch clean. > > $ find drivers/staging/olpc_dcon/ -name > "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut > -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep > for up to 20ms; see Documentation/timers/timers-howto.txt 3 WARNING:
NACK - please don't modify the msleep timings right now. The pr_* changes are welcome, however.
> Prefer pr_debug(... to printk(KERN_DEBUG, ... 3 WARNING: Prefer > pr_warn(... to printk(KERN_WARNING, ... 6 WARNING: Prefer > pr_info(... to printk(KERN_INFO, ... 19 WARNING: Prefer pr_err(... > to printk(KERN_ERR, ... > > And added pr_fmt. > > Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> [...]
| |