Messages in this thread | | | Date | Fri, 27 Jul 2012 14:05:49 +0900 | Subject | Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings | From | Toshiaki Yamane <> |
| |
On Fri, Jul 27, 2012 at 2:03 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: >> fixed some checkpatch warnings. >> (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) > [] >> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > [] >> @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init) >> >> ver = dcon_read(dcon, DCON_REG_ID); >> if ((ver >> 8) != 0xDC) { >> - printk(KERN_ERR "olpc-dcon: DCON ID not 0xDCxx: 0x%04x instead.\n", >> - ver); >> + pr_err("DCON ID not 0xDCxx: 0x%04x instead.\n", >> + ver); > > Please fit arguments on a single line where feasible.
I agree.
| |