Messages in this thread | | | Subject | RE: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits | Date | Mon, 2 Apr 2012 10:18:02 +0100 | From | "David Laight" <> |
| |
> The function is renamed to make it a little more clear what it does. > It is not added to any .h because it is not for general > consumption, only for bpf internal use (and so by the jits).
I'd have thought it better to put in into a bfp_internal.h (or similar) with a big warning there about the asm users.
Possibly even worth adding some other defs that the asm files will need (if there are any).
David
| |